[HFix] : Fix JS exception because of Zeppelin-2519#2392
Closed
vipul1409 wants to merge 10 commits into
Closed
Conversation
added 10 commits
May 9, 2017 20:59
Member
|
Thanks @vipul1409 for the hot fix. Tested and it fixes JS exception. Merge to master as a hot fix. |
Member
|
@vipul1409 Thanks for the quick fix. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix JS exception because of Zeppelin-2519. Added the missing dependency for scroll monitor before viewport.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2519
How should this be tested?
Load a notebook and you should not see any exceptions in the dev console.
Screenshots (if appropriate)
Questions: